Finishing a Development Branch

VerifiedCaution

Guides completion of a development branch by verifying tests pass, then presenting exactly four structured options: merge locally, create a PR, keep the branch, or discard it. Executes the chosen workflow with proper worktree cleanup.

Sby Skills Guide Bot
DevelopmentIntermediate
706/2/2026
Claude Code
#git#branch-management#workflow#pull-request#merge

Recommended for

Our review

Guides the completion of a development branch by presenting structured options after test verification.

Strengths

  • Ensures tests pass before any action
  • Provides clear, limited choices to avoid ambiguity
  • Automates Git operations with confirmation
  • Cleans up worktrees automatically

Limitations

  • Requires CLI tools (Git, gh) to be configured
  • Does not handle advanced merge conflicts
  • Assumes a standard base branch (main/master)
When to use it

When implementation is complete, tests pass, and you need to integrate the work cleanly.

When not to use it

If tests are still failing or you want to keep uncommitted changes.

Security analysis

Caution
Quality score92/100

The skill uses bash commands for standard git operations and test execution. While it has safety checks (confirmation for discard, test verification), the destructive nature of branch deletion and worktree removal warrant caution. No external data exfiltration or security bypasses are present.

Findings
  • Skill performs destructive Git operations (branch deletion, worktree removal) that could lead to data loss if used improperly or if confirmation step is bypassed.
  • Executes project-specific test commands (e.g., npm test, pytest) which could run arbitrary code if the test suite is maliciously crafted, though this is inherent to the development workflow.

Examples

Finish feature branch
I've completed the feature, all tests pass, and I want to merge back to main.
Create a PR for completed work
My branch is ready, tests pass. Push and create a pull request.
Discard branch after changes were wrong
This branch was a mistake. Delete it and go back to main.

name: finishing-a-development-branch description: Use when implementation is complete, all tests pass, and you need to decide how to integrate the work - guides completion of development work by presenting structured options for merge, PR, or cleanup

Finishing a Development Branch

Overview

Guide completion of development work by presenting clear options and handling chosen workflow.

Core principle: Verify tests → Present options → Execute choice → Clean up.

Announce at start: "I'm using the finishing-a-development-branch skill to complete this work."

The Process

Step 1: Verify Tests

Before presenting options, verify tests pass:

# Run project's test suite
npm test / cargo test / pytest / go test ./...

If tests fail:

Tests failing (<N> failures). Must fix before completing:

[Show failures]

Cannot proceed with merge/PR until tests pass.

Stop. Don't proceed to Step 2.

If tests pass: Continue to Step 2.

Step 2: Determine Base Branch

# Try common base branches
git merge-base HEAD main 2>/dev/null || git merge-base HEAD master 2>/dev/null

Or ask: "This branch split from main - is that correct?"

Step 3: Present Options

Present exactly these 4 options:

Implementation complete. What would you like to do?

1. Merge back to <base-branch> locally
2. Push and create a Pull Request
3. Keep the branch as-is (I'll handle it later)
4. Discard this work

Which option?

Don't add explanation - keep options concise.

Step 4: Execute Choice

Option 1: Merge Locally

# Switch to base branch
git checkout <base-branch>

# Pull latest
git pull

# Merge feature branch
git merge <feature-branch>

# Verify tests on merged result
<test command>

# If tests pass
git branch -d <feature-branch>

Then: Cleanup worktree (Step 5)

Option 2: Push and Create PR

# Push branch
git push -u origin <feature-branch>

# Create PR
gh pr create --title "<title>" --body "$(cat <<'EOF'
## Summary
<2-3 bullets of what changed>

## Test Plan
- [ ] <verification steps>
EOF
)"

Then: Cleanup worktree (Step 5)

Option 3: Keep As-Is

Report: "Keeping branch <name>. Worktree preserved at <path>."

Don't cleanup worktree.

Option 4: Discard

Confirm first:

This will permanently delete:
- Branch <name>
- All commits: <commit-list>
- Worktree at <path>

Type 'discard' to confirm.

Wait for exact confirmation.

If confirmed:

git checkout <base-branch>
git branch -D <feature-branch>

Then: Cleanup worktree (Step 5)

Step 5: Cleanup Worktree

For Options 1, 2, 4:

Check if in worktree:

git worktree list | grep $(git branch --show-current)

If yes:

git worktree remove <worktree-path>

For Option 3: Keep worktree.

Quick Reference

| Option | Merge | Push | Keep Worktree | Cleanup Branch | |--------|-------|------|---------------|----------------| | 1. Merge locally | ✓ | - | - | ✓ | | 2. Create PR | - | ✓ | ✓ | - | | 3. Keep as-is | - | - | ✓ | - | | 4. Discard | - | - | - | ✓ (force) |

Common Mistakes

Skipping test verification

  • Problem: Merge broken code, create failing PR
  • Fix: Always verify tests before offering options

Open-ended questions

  • Problem: "What should I do next?" → ambiguous
  • Fix: Present exactly 4 structured options

Automatic worktree cleanup

  • Problem: Remove worktree when might need it (Option 2, 3)
  • Fix: Only cleanup for Options 1 and 4

No confirmation for discard

  • Problem: Accidentally delete work
  • Fix: Require typed "discard" confirmation

Red Flags

Never:

  • Proceed with failing tests
  • Merge without verifying tests on result
  • Delete work without confirmation
  • Force-push without explicit request

Always:

  • Verify tests before offering options
  • Present exactly 4 options
  • Get typed confirmation for Option 4
  • Clean up worktree for Options 1 & 4 only

Integration

Called by:

  • subagent-driven-development (Step 7) - After all tasks complete
  • executing-plans (Step 5) - After all batches complete

Pairs with:

  • using-git-worktrees - Cleans up worktree created by that skill

Saving Next Steps

When finishing-a-development-branch work is complete or paused:

node .claude/skills/work-command-center/tools/add-skill-next-steps.js \
  --skill "finishing-a-development-branch" \
  --content "## Priority Tasks
1. Complete final testing on feature branch
2. Decide merge strategy (PR vs direct merge)
3. Clean up development branch"

See: .claude/skills/work-command-center/skill-next-steps-convention.md

Related skills